137
editsUser talk:HiddenDragon: Difference between revisions
Jump to navigation
Jump to search
→Tenacity and Topple weapon actions
Llamageddon (talk | contribs) |
|||
| (11 intermediate revisions by 5 users not shown) | |||
| Line 12: | Line 12: | ||
:Just mentioning, after reading above comment, I do use talk pages, and most wikis do. Discord has a lot of downsides for coordinating wiki editing, which nearly everyone actually using it admits to, so do use talk pages if you want to. If nothing else, casual editors or experienced ones passing through would only be checking talk pages by default. Relevant info there is very likely to be useful to someone at some point. [[User:Llamageddon|Llamageddon]] ([[User talk:Llamageddon|talk]]) 12:33, 3 October 2023 (CEST) | :Just mentioning, after reading above comment, I do use talk pages, and most wikis do. Discord has a lot of downsides for coordinating wiki editing, which nearly everyone actually using it admits to, so do use talk pages if you want to. If nothing else, casual editors or experienced ones passing through would only be checking talk pages by default. Relevant info there is very likely to be useful to someone at some point. [[User:Llamageddon|Llamageddon]] ([[User talk:Llamageddon|talk]]) 12:33, 3 October 2023 (CEST) | ||
:: As referenced in [[Talk:Guardian_of_Faith_(Passive_Feature)]], the current status quo seems to be using the tooltip/controller icons '''on''' the passive feature pages, especially since a simple hover on the passive feature on PC shows said tooltip icon. If we edit [[Template:PAS]] to be its own template instead of calling into [[Template:SAI]], we could probably start using the rounded background versions of passive feature icons there. - [[User:Sky|Sky]] ([[User talk:Sky|talk]]) 15:44, 3 October 2023 (CEST) | |||
::: We might wanna start uploading the round icons as {{InfoBlob|Feature_Name_Round.webp}} then [[Template:PAS]] could be modified to use {{InfoBlob|<nowiki>File:{{{Page Name}}}_Round.webp</nowiki>}} instead of Icon.webp - [[User:HINK|HINK]] ([[User talk:HINK|talk]]) 16:08, 3 October 2023 (CEST) | |||
:::: I think it's better to upload square icons (e.g. {{InfoBlob|<nowiki>File:{{{Page Name}}}_Square.webp</nowiki>}}) and then have [[Template:PAS]] use them and round them in CSS. Passive Effects are rounded in-game after all, plus we could re-use it again for Conditions which use the same images but smaller.--[[User:HiddenDragon|HiddenDragon]] ([[User talk:HiddenDragon|talk]]) 17:02, 3 October 2023 (CEST) | |||
: Even though they're never used in game, I generally prefer to use them because they are super clean icons with no fade or background. An argument could be made that perhaps we should use the square (circle-cropped) images for Passive Effects (since that's how it looks in game) but for some time now {{InfoBlob|<nowiki>File:{{{Page Name}}}_Icon.webp</nowiki>}} are all the controller icons so I'd like to keep it consistent that way.--[[User:HiddenDragon|HiddenDragon]] ([[User talk:HiddenDragon|talk]]) 17:17, 3 October 2023 (CEST) | |||
:: There is no need to round them either, a template can easily use the CSS {{C|border-radius: 50%;}}. It's frustratingly simple, but unfortunately unsanctioned live CSS use has been strongly advised against by mods, so still waiting on that, but prefer that to another set of file types to upload and manage. Ideally, I see no reason why both icon types can't be uploaded and used if/when needed, rather than overwriting everything, but as you noticed, this has been quite strenuously shot down yet again. Under the circumstances, I can't really argue against you choosing to overwrite everything with the radial menu icons instead. I would love to see them being used on things like character screens, and IMO for inline use when contextually relevant. Thanks for the explanation of what was happening with these BTW, I was late to notice, but it explains at least one thing I was unclear about. [[User:Llamageddon|Llamageddon]] ([[User talk:Llamageddon|talk]]) 18:21, 4 October 2023 (CEST) | |||
::: [[User:Llamageddon/Test2|Sandbox example]] of style rounding of square icon for use inline, at bottom of page, if you are interested. Pretty sure it's functionally exactly what the game is doing. [[User:Llamageddon|Llamageddon]] ([[User talk:Llamageddon|talk]]) | |||
:::: For what its worth, I think we DO want to use rounded images for the Character Box and for all Conditions but it's...a bit complicated. Passive Effects, Reactions, Conditions all draw from the same icon set and we ''want'' to make it work with [[Template:PAS]] and [[Template:Cond]], but it's not quite so simple. To complicate things further, effects granted from Items also show up in the character box but they use images from the items set (they are still rounded for display, interestingly). We ''should'' have all the icons uploaded at some point, but we need to make sure there's a naming scheme that makes sense for these. --[[User:HiddenDragon|HiddenDragon]] ([[User talk:HiddenDragon|talk]]) 07:06, 5 October 2023 (CEST) | |||
::: "unsanctioned live CSS use has been strongly advised against by mods" It's more like inline css is not ''optimal'', but there's a lot of inline css use anyways, including by yours truly. 😅 I would say that inline css that's not related to colours is probably okay even if ideally it should be moved into common.css. Inline css that applies colours is discouraged because we do have four skins with different colour schemes, the most challenging pair of which is Vector Dark-Grey vs Vector Default. Citizen is dark-ish so it's usually fine. - [[User:Sky|Sky]] ([[User talk:Sky|talk]]) 11:04, 5 October 2023 (CEST) | |||
::::Regarding rounded images, we already have every icon rounded, I batch-converted and uploaded them on Discord, [https://drive.google.com/file/d/12bborxRsPw9-rA4c-7E8O7hCMsEWARLl/view?usp=sharing but here they are as well]. - [[User:HINK|HINK]] ([[User talk:HINK|talk]]) 11:39, 5 October 2023 (CEST) | |||
== Tenacity and Topple weapon actions == | |||
I noticed that on several quarterstaff and greatclub/flail/morningstar/maul pages you added the [[Topple]] and [[Tenacity]] actions (respectively) under the "special" field instead of the "weapon actions" field. May I ask why? Most other common weapon actions (for example, [[Flourish]] on Shortswords) are placed under the "weapon actions" category. Additionally, placing this under "special" causes it to show up in the "Special" column on database search tables (for example, the [[List of weapons]] page), when that seems to be generally reserved for unique weapon passives or spells. [[User:Willach|Willach]] ([[User talk:Willach|talk]]) 01:41, 12 January 2024 (CET) | |||
: Hi, those weapon actions are different from the usual weapon actions. Neither of them require proficiency to use, plus on the tooltip they're distinctly separate from the usual weapon actions for the same reason. That's the reason right now. There might be a better way to do it later, but this emulates how it is ingame. --[[User:HiddenDragon|HiddenDragon]] ([[User talk:HiddenDragon|talk]]) 06:50, 12 January 2024 (CET) | |||
:: Ah, I see. Thanks for clearing that up - I was confused why some stuff showed up in the tables and others didn't! [[User:Willach|Willach]] ([[User talk:Willach|talk]]) 23:29, 13 January 2024 (CET) | |||